Add database serializers db_to_string, db_of_string. #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to be able to save the lease database in disk.
Preserve old code and wrap it into a try catch, this is easier and safer than screwing up the tests. At least we get a uniform output when we run tests.
The test was running twice, and for some reason it would fail with ENOENT failed: open: ENOENT /src/_build/default/test/_build/_tests/server tests/state progression.003.output). My suspicion is alcotest does something in paralel and there is some kind of race. At anyrate, we don't want to run things twice.
|
looks good to me, thanks! |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Oct 27, 2021
…t (1.4.1) CHANGES: * Add database serializers (db_of_string/db_to_string) mirage/charrua#112 @haesbaert * Remove rresult dependency (mirage/charrua#114 @hannesm) * Avoid deprecated Cstruct.len function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to be able to save the lease database in disk.