Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests about adler32 #80

Merged
merged 2 commits into from Apr 11, 2023
Merged

Add tests about adler32 #80

merged 2 commits into from Apr 11, 2023

Conversation

dinosaure
Copy link
Member

Spotted by @balat in Irmin, I made a reproduction of an error from checkseum‧ocaml. I will try to fix it on this PR.

@dinosaure
Copy link
Member Author

The error was introduced by this commit: 0904227 (only for v0.5.0). I will cut a release and disallow checkseum.0.5.0 on opam-repository. It's mainly due to the lack of tests about adler32.

@dinosaure dinosaure merged commit df4b880 into main Apr 11, 2023
7 checks passed
@dinosaure dinosaure deleted the fix-adler32-ocaml branch April 11, 2023 11:12
dinosaure added a commit to dinosaure/opam-repository that referenced this pull request Apr 11, 2023
CHANGES:

- Fix regression on `adler32` (the OCaml version) introduced by mirage/checkseum#76 and spotted
  by @balat (@dinosaure, mirage/checkseum#80). We advise the user to upgrade as soon as he/she
  can `checkseum`. `checkseum.0.5.0` will be disabled with this release.
- Fix the CI on Windows (@dinosaure, @MisterDA, mirage/checkseum#79)
  See (mirage/bechamel#41 for more details)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant