Fix internal list pretty-printer (discovered by @hannesm) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This kind of tests make sure that the pretty-printer works but it does not highlight some assumptions such as the isomorphisme between the encoder and the decoder.
|
The last commit fix another issue about decoding quoted string. First at all, I need to fill the PR with some others tests about pretty-printer but seems good enough for me to:
Even if |
This was referenced Nov 19, 2020
Closed
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Nov 19, 2020
CHANGES: - Add some tests to check the behavior of the pretty-printer (@dinosaure, mirage/emile#14) - Fix the implementation of the quoted-string (@dinosaure, mirage/emile#14) - Fix internal list pretty-printer (discovered by @hannes, @dinosaure, mirage/emile#14)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit sad to introduce this kind of bug... I will add some tests to check the behavior of the pretty-printer.