index: release the merge lock if a merge raises an exception #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samoht
reviewed
Apr 28, 2021
craigfe
force-pushed
the
test-hook-release-semaphore-lock
branch
3 times, most recently
from
3e73ade
to
3fd6edd
Compare
craigfe
changed the title
samoht
approved these changes
Apr 28, 2021
craigfe
force-pushed
the
test-hook-release-semaphore-lock
branch
from
3fd6edd
to
1bd7437
Compare
craigfe
force-pushed
the
test-hook-release-semaphore-lock
branch
from
5581c86
to
c1a7cf5
Compare
|
Rebased. |
samoht
reviewed
Apr 28, 2021
| match t.index with | ||
| | None -> Tbl.length log.mem | ||
| | Some index -> | ||
| (Int63.to_int (IO.offset index.io) / Entry.encoded_size) |
There was a problem hiding this comment.
This is broken in 32 bit but we probably do not care :-)
|
LGTM |
craigfe
added a commit
to craigfe/index
that referenced
this pull request
Apr 28, 2021
Fixes the bug spotted here: mirage#312 (comment). I think `Int63.to_int` is a little too tempting from an API perspective, so I've shadowed it and provided more clearly named checked and unchecked alternatives.
craigfe
added a commit
to craigfe/index
that referenced
this pull request
Apr 28, 2021
Fixes the bug spotted here: mirage#312 (comment). I think `Int63.to_int` is a little too tempting from an API perspective, so I've shadowed it and provided more clearly named checked and unchecked alternatives.
samoht
added a commit
to samoht/opam-repository
that referenced
this pull request
Apr 29, 2021
CHANGES: ## Fixed - Reduce allocations during merge (mirage/index#274, mirage/index#277) - Protect concurrent syncs with a lock (mirage/index#309) - Fixed a performance issue for `Index.sync` when there is a blocking merge in progress: the `log_async` file was not cached properly and fully reloaded from disk every time. (mirage/index#310) - Release the merge lock if a merge raises an exception (mirage/index#312) - Added fsync after `Index.clear` to signal more quickly to read-only instances than something has changed in the file (mirage/index#308) ## Changed - Specialise `IO.v` to create read-only or read-write instances. (mirage/index#291) - `clear` removes the files on disks and opens new ones containing only the header. (mirage/index#288, mirage/index#307, mirage/index#317)
samoht
added a commit
to samoht/opam-repository
that referenced
this pull request
Apr 29, 2021
CHANGES: ## Fixed - Reduce allocations during merge (mirage/index#274, mirage/index#277) - Protect concurrent syncs with a lock (mirage/index#309) - Fixed a performance issue for `Index.sync` when there is a blocking merge in progress: the `log_async` file was not cached properly and fully reloaded from disk every time. (mirage/index#310) - Release the merge lock if a merge raises an exception (mirage/index#312) - Added fsync after `Index.clear` to signal more quickly to read-only instances than something has changed in the file (mirage/index#308) ## Changed - Specialise `IO.v` to create read-only or read-write instances. (mirage/index#291) - `clear` removes the files on disks and opens new ones containing only the header. (mirage/index#288, mirage/index#307, mirage/index#317)
samoht
added a commit
to samoht/opam-repository
that referenced
this pull request
Apr 29, 2021
CHANGES: ## Fixed - Reduce allocations during merge (mirage/index#274, mirage/index#277) - Protect concurrent syncs with a lock (mirage/index#309) - Fixed a performance issue for `Index.sync` when there is a blocking merge in progress: the `log_async` file was not cached properly and fully reloaded from disk every time. (mirage/index#310) - Release the merge lock if a merge raises an exception (mirage/index#312) - Added fsync after `Index.clear` to signal more quickly to read-only instances than something has changed in the file (mirage/index#308) ## Changed - Specialise `IO.v` to create read-only or read-write instances. (mirage/index#291) - `clear` removes the files on disks and opens new ones containing only the header. (mirage/index#288, mirage/index#307, mirage/index#317)
samoht
added a commit
to samoht/opam-repository
that referenced
this pull request
Apr 29, 2021
CHANGES: - Reduce allocations during merge (mirage/index#274, mirage/index#277) - Protect concurrent syncs with a lock (mirage/index#309) - Fixed a performance issue for `Index.sync` when there is a blocking merge in progress: the `log_async` file was not cached properly and fully reloaded from disk every time. (mirage/index#310) - Release the merge lock if a merge raises an exception (mirage/index#312) - Added fsync after `Index.clear` to signal more quickly to read-only instances than something has changed in the file (mirage/index#308) - Specialise `IO.v` to create read-only or read-write instances. (mirage/index#291) - `clear` removes the files on disks and opens new ones containing only the header. (mirage/index#288, mirage/index#307, mirage/index#317)
craigfe
added a commit
to craigfe/index
that referenced
this pull request
Apr 29, 2021
Fixes the bug spotted here: mirage#312 (comment). I think `Int63.to_int` is a little too tempting from an API perspective, so I've shadowed it and provided more clearly named checked and unchecked alternatives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has no effect on passing tests, but causes failing ones to behave more sensibly in the short term. A more complete solution would fix #284 entirely.