Work with fsevents/cf libs #31
Conversation
| "inotify" {os = "linux"} | ||
| "osx-fsevents" {os = "macos" & >= "0.2.0"} | ||
| "inotify" {os = "linux"} | ||
| "cf-lwt" |
There was a problem hiding this comment.
| "cf-lwt" | |
| "cf-lwt" {os = "macos"} |
There was a problem hiding this comment.
actually not needed any more -- I modified the dependent libraries to be optional but installable on Linux, so it'll work in a duniverse. So they can be firm dependencies now.
There was a problem hiding this comment.
I think it's better to not force these dependencies if possible (to avoid future compilation issues on Linux due to unrelated issues on macos).
There was a problem hiding this comment.
we need it to work in a duniverse though. The non-macOS builds don't do anything on Linux at all -- i used enabled_if to just not compile them when system <> macOS. https://github.com/mirage/ocaml-cf/blob/main/lib/dune#L7
So the whole dependency should be a noop if os != macos (but it will jsut work if irmin-watcher is cloned into a duniverse and compiled on a mac)
| "osx-fsevents" {os = "macos" & >= "0.2.0"} | ||
| "inotify" {os = "linux"} | ||
| "cf-lwt" | ||
| "fsevents-lwt" |
There was a problem hiding this comment.
| "fsevents-lwt" | |
| "fsevents-lwt" {os = "macos"} |
|
I'm merging this one so that we can unlock the build in a dune monorepo. |
CHANGES: - Switch to GitHub Actions from Travis (mirage/irmin-watcher#31, @avsm) - Initialise backends only when needed via a lazy watcher interface (mirage/irmin-watcher#31, @samoht @avsm) - Use fsevents and cf-lwt packages (mirage/irmin-watcher#31, @avsm) - Use ocamlformat.0.18.0 (mirage/irmin-watcher#31, @avsm)
Supersedes #23