Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust merges #72

Closed
samoht opened this issue Jun 26, 2014 · 2 comments
Closed

More robust merges #72

samoht opened this issue Jun 26, 2014 · 2 comments
Labels
type/bug Related to a bug

Comments

@samoht
Copy link
Member

samoht commented Jun 26, 2014

Currently, there are two situations that Irmin do not handler very well:

  • trying to merge when no parents in common. This usually do not happen, but why not try to support it (even if it is not very efficient). Also, it might be necessary to handle if we deal with partial history (see Fixes #21). This means adding a merge2 function in user-defined contents.
  • trying to merge where multiple common ancestor exists. Currently, Irmin fails (see https://github.com/mirage/irmin/blob/master/lib/core/irminCommit.ml#L180) but we should be able to 3-merge all the pair of parents recursively to get a unique ancestor.
@yansh
Copy link

yansh commented Nov 11, 2014

@samoht Strange it still throws the exception for me. Has the irmin package been updated or I need to compile it from the source? sorry, I thought this bug was resolved :) @niksu

samoht added a commit to samoht/irmin that referenced this issue Dec 18, 2014
@samoht
Copy link
Member Author

samoht commented Jan 5, 2015

Fixed in 0.9.0

@samoht samoht closed this as completed Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Related to a bug
Projects
None yet
Development

No branches or pull requests

2 participants