New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
irmin-pack: add a migration function to the V2 format #1070
Conversation
Aside: if we suspect this migration is very disruptive to users, perhaps we should consider adding some amount of blank header space to the IO files in case a future format change can quickly take advantage of those. |
Needing to extract |
fdfa75f
to
8453d10
Compare
The progress bar tests seem broken |
8453d10
to
3ce09be
Compare
Indeed... that's what I get for using this PR as a way to get code onto comanche... Fixed. |
Could you rebase on top of master now that #1072 is merged? |
Co-authored-by: icristescu <domninac@gmail.com>
3ce09be
to
0e74eab
Compare
@samoht: Done. |
Thanks! The new code looks indeed cleaner and simpler. Merging now. |
This contains a subset of the changes from #1015, but uses a different implementation strategy: rather than iterating over all of the objects in the V1 store and adding them individually to the V2 store, we delegate migration to the
IO
instances (which just shift everything along the appropriate number of bytes). This avoids some unnecessary work.Other differences:
index
at all – the Index format has not changed (yet... CC @pascutto);