Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

irmin-pack: clarify uses of Bytes.unsafe_{to,of}_string #1970

Merged
merged 8 commits into from
Jul 8, 2022
Merged

irmin-pack: clarify uses of Bytes.unsafe_{to,of}_string #1970

merged 8 commits into from
Jul 8, 2022

Commits on Jul 7, 2022

  1. Bytes.unsafe_to_string: comments after pass through irmin-pack code 

    For each occurrence of Bytes.unsafe_to_string, I have commented on
whether or not the use is safe. Some are, some are not, and for some it
is not clear whether they are safe or not.
    @tomjridge
    tomjridge committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    03f37e5 View commit details
    Browse the repository at this point in the history

  2. irmin-pack: Bytes.unsafe_to_string: comments on occurrences 

    Each occurrence of unsafe_to_string in irmin-pack has been marked with
a comment as to whether the use is safe or not.
    @tomjridge
    tomjridge committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    eb1af2e View commit details
    Browse the repository at this point in the history

  3. irmin-pack: add comments on safe uses of Bytes.unsafe_to_string 

    Comments use the terminology from the manual ("unique ownership" and
"shared ownership").
    @tomjridge
    tomjridge committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    1ab1404 View commit details
    Browse the repository at this point in the history

  4. irmin-pack: add comments on safe usages of Bytes.unsafe_of_string

    @tomjridge
    tomjridge committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    5b0716d View commit details
    Browse the repository at this point in the history

  5. irmin-pack: further clarify uses of Bytes.unsafe_{to,of}_string

    @tomjridge
    tomjridge committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    12a01cd View commit details
    Browse the repository at this point in the history

  6. irmin-pack: further clarify uses of Bytes.unsafe_to_string

    @tomjridge
    tomjridge committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    266ba02 View commit details
    Browse the repository at this point in the history

  7. irmin-pack: remove unnecessary comment

    @tomjridge
    tomjridge committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    15207cf View commit details
    Browse the repository at this point in the history

  8. irmin-pack: further tweaks and clarifications after initial review

    @tomjridge
    tomjridge committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    97340db View commit details
    Browse the repository at this point in the history