Gc stats #2089
Gc stats #2089
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2089 +/- ##
==========================================
- Coverage 64.69% 64.49% -0.20%
==========================================
Files 132 131 -1
Lines 15719 15828 +109
==========================================
+ Hits 10169 10208 +39
- Misses 5550 5620 +70
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
|
I usually think that "utils" are a code smell. Sometimes they are warranted as a collection of utility functions, but I usually want to pause and think about what I'm actually trying to model by stuffing things into a "utils". I don't know if this translates well, but I see them as the junk drawer of code bases. 🗑️ As for gc specifically, I shied away from it previously because of the above utils issue, but also I didn't see a strong need to pull apart the module since it all works as one unit anyway (the almost identical All that to say, I wouldn't be opposed to splitting the file, but I would just like to see a better modelling than a utils file. 😉 |
Ngoguey42
force-pushed
the
gc-stats
branch
2 times, most recently
from
9b1f1bb
to
dc4c3ce
Compare
|
This is now ready for review. |
There was a problem hiding this comment.
I've done a high level review pass (not looking closely at the details of the stats calculations). I really (really) think we ought to separate these stats from the ones surfaced in the public API. Left a few other comments, but this my only real change request for this PR. Thanks for doing the work to get these stats in place!
|
I'm done with this PR. I'll clean the commit history prior to merge, following approves |
…ils, irmin-test, irmin-pack, irmin-mirage, irmin-mirage-graphql, irmin-mirage-git, irmin-http, irmin-graphql, irmin-git, irmin-fs, irmin-containers, irmin-cli, irmin-chunk and irmin-bench (3.5.0)
CHANGES:
### Added
- **irmin-pack**
- Add `Irmin_pack_unix.Stats.Latest_gc` which is now the parameter of GC's
`finished` callback (mirage/irmin#2089, @Ngoguey42)
- Add `Gc.oldest_live_commit` which returns the key of the commit on which the
latest gc was called on. (mirage/irmin#2110, @icristescu)
- Add `split` to create a new suffix chunk. Subsequent writes will append to
this chunk until `split` is called again. (mirage/irmin#2118, @icristescu)
- Add `create_one_commit_store` to create a new store from the existing one,
containing only one commit. (mirage/irmin#2125, @icristescu)
### Changed
- **irmin-pack**
- Upgraded on-disk format to version 4. (mirage/irmin#2110, @icristescu)
- Detecting control file corruption with a checksum (mirage/irmin#2119, @art-w)
- Change on-disk layout of the suffix from a single file to a multiple,
chunked file design (mirage/irmin#2115, @metanivek)
- Modify GC to work with new chunked suffix. See `examples/gc.ml` for a
demonstration of how it works with the new `split` function. (mirage/irmin#2126,
@metanivek)
### Fixed
…ils, irmin-test, irmin-pack, irmin-mirage, irmin-mirage-graphql, irmin-mirage-git, irmin-http, irmin-graphql, irmin-git, irmin-fs, irmin-containers, irmin-cli, irmin-chunk and irmin-bench (3.5.0)
CHANGES:
### Added
- **irmin-pack**
- Add `Irmin_pack_unix.Stats.Latest_gc` which is now the parameter of GC's
`finished` callback (mirage/irmin#2089, @Ngoguey42)
- Add `Gc.oldest_live_commit` which returns the key of the commit on which the
latest gc was called on. (mirage/irmin#2110, @icristescu)
- Add `split` to create a new suffix chunk. Subsequent writes will append to
this chunk until `split` is called again. (mirage/irmin#2118, @icristescu)
- Add `create_one_commit_store` to create a new store from the existing one,
containing only one commit. (mirage/irmin#2125, @icristescu)
### Changed
- **irmin-pack**
- Upgraded on-disk format to version 4. (mirage/irmin#2110, @icristescu)
- Detecting control file corruption with a checksum (mirage/irmin#2119, @art-w)
- Change on-disk layout of the suffix from a single file to a multiple,
chunked file design (mirage/irmin#2115, @metanivek)
- Modify GC to work with new chunked suffix. See `examples/gc.ml` for a
demonstration of how it works with the new `split` function. (mirage/irmin#2126,
@metanivek)
### Fixed
No description provided.