Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Conf.pp and Conf.equal #2227

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Add Conf.pp and Conf.equal #2227

merged 3 commits into from
Mar 28, 2023

Conversation

samoht
Copy link
Member

@samoht samoht commented Mar 27, 2023

No description provided.

@samoht samoht mentioned this pull request Mar 27, 2023
Merged
metanivek
metanivek reviewed Mar 27, 2023
View reviewed changes
src/irmin/conf.ml Outdated Show resolved Hide resolved
metanivek
metanivek approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@metanivek metanivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samoht samoht force-pushed the conf branch 2 times, most recently from caa1801 to d195a44 Compare March 28, 2023 10:07
@samoht
Copy link
Member Author

samoht commented Mar 28, 2023

The coverage test fails with:

  ASSERT Chunk0 removed
  File "test/irmin-pack/test_gc.ml", line 1224, character 4:
  FAIL Chunk0 removed
  
     Expected: `false'
     Received: `true'
  
  Raised at Alcotest_engine__Test.check in file "src/alcotest-engine/test.ml", line 200, characters 4-261
  Called from Test_pack__Test_gc.Split.v3_migrated_store_splits_and_gc in file "test/irmin-pack/test_gc.ml", line 1224, characters 4-120
  Called from Lwt.Sequential_composition.bind.create_result_promise_and_callback_if_deferred.callback in file "src/core/lwt.ml", line 1849, characters 23-26

Which doesn't seem related.

art-w
art-w reviewed Mar 28, 2023
View reviewed changes
src/irmin/conf.ml Outdated Show resolved Hide resolved
@art-w
Copy link
Contributor

art-w commented Mar 28, 2023

Thanks! Indeed the failure shouldn't block your PR, I'm guessing it's related to the async deletion of chunk files which makes this test flaky ( #2221 , cc @adatario )

@samoht samoht merged commit bc35f04 into mirage:main Mar 28, 2023
@samoht samoht deleted the conf branch March 28, 2023 17:51
@adatario adatario mentioned this pull request Mar 29, 2023
Merged
2 tasks
@metanivek metanivek mentioned this pull request Apr 21, 2023
Merged
metanivek added a commit to metanivek/opam-repository that referenced this pull request Apr 21, 2023
@metanivek
[new release] ppx_irmin, libirmin, irmin, irmin-tezos, irmin-test, ir…
2adfe8b 
…min-pack, irmin-pack-tools, irmin-mirage, irmin-mirage-graphql, irmin-mirage-git, irmin-http, irmin-graphql, irmin-git, irmin-fs, irmin-containers, irmin-cli, irmin-chunk and irmin-bench (3.7.0)

CHANGES:

### Added

- **irmin**
  - Add `Conf.pp` and `Conf.equal` to print and compare configuration values
    (mirage/irmin#2227, @samoht)
  - Add a `clear` optional arguments to all function that adds a new commit:
    `Commit.v`, `set`, `set_tree`, `remove`, `test_and_set`,
    `test_and_set_tree`, `test_set_and_get`, `test_set_and_get_tree`, `merge`,
    `merge_tree` and `with_tree`. This new argument allows to control whether
    the tree caches are cleared up after objects are exported to disk during
    the commit. (mirage/irmin#2225, @samoht)

- **irmin-pack**
  - Add configuration option, `lower_root`, to specify a path for archiving data
    during a GC. (mirage/irmin#2177, @metanivek)
  - Add `is_split_allowed` to check if a store allows split. (mirage/irmin#2175, @metanivek)
  - Add `add_volume` to allow creating new empty volume in lower layer. (mirage/irmin#2188,
    @metanivek)
  - Add a `behaviour` function to the GC to check wether the GC will archive or
    delete data. (mirage/irmin#2190, @Firobe)
  - Add a migration on `open_rw` to move the data to the `lower_root` if
    the configuration was enabled (mirage/irmin#2205, @art-w)

### Changed

- **irmin**
  - Expose type equality for `Schema.Info` to avoid defining the `info` function
    multiple times when using similar stores (mirage/irmin#2189, mirage/irmin#2193, @samoht)
- **irmin-pack**
  - GC now changes its behaviour depending on the presence of a lower layer.
    (mirage/irmin#2190, @Firobe)
  - Split now raises an exception if it is not allowed. It is not allowed on
    stores that do not allow GC. (mirage/irmin#2175, @metanivek)
  - GC now supports stores imported V1/V2 stores, in presence of a lower layer
    only. (mirage/irmin#2190, @art-w, @Firobe)
  - Upgrade on-disk format to version 5. (mirage/irmin#2184, @metanivek)
  - Archive to lower volume does not copy orphaned commits. (mirage/irmin#2215, @art-w)

### Fixed
- **irmin-pack**
  - Unhandled exceptions in GC worker process are now reported as a failure
    (mirage/irmin#2163, @metanivek)
  - Fix the silent mode for the integrity checks. (mirage/irmin#2179, @icristescu)
  - Fix file descriptor leak caused by `mmap`. (mirage/irmin#2232, @art-w)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@art-w art-w art-w approved these changes

@metanivek metanivek metanivek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samoht @art-w @metanivek