Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irmin-pack: fix snapshot export #2257

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Conversation

metanivek
Copy link
Member

GC-based snapshot export did not work if called with a commit that is older than the latest GC commit.

@metanivek metanivek requested review from art-w and adatario June 9, 2023 14:30
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023

Codecov Report

❗ No coverage uploaded for pull request base (3.7@6851cba). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 8dea941 differs from pull request most recent head db29141. Consider uploading reports for the commit db29141 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@          Coverage Diff           @@
##             3.7    #2257   +/-   ##
======================================
  Coverage       ?   68.14%           
======================================
  Files          ?      137           
  Lines          ?    16668           
  Branches       ?        0           
======================================
  Hits           ?    11359           
  Misses         ?     5309           
  Partials       ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@art-w art-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 👍

GC-based snapshot export did not work if called with a commit that is
older than the latest GC commit.
@metanivek
Copy link
Member Author

Will merge once we have confirmation it fixes downstream issues.

@metanivek metanivek merged commit 1bf38b3 into mirage:3.7 Jun 15, 2023
3 of 4 checks passed
@metanivek metanivek deleted the fix-gc-snapshot branch June 15, 2023 13:45
metanivek added a commit to metanivek/opam-repository that referenced this pull request Jun 15, 2023
…min-pack, irmin-pack-tools, irmin-mirage, irmin-mirage-graphql, irmin-mirage-git, irmin-http, irmin-graphql, irmin-git, irmin-fs, irmin-containers, irmin-cli, irmin-chunk and irmin-bench (3.7.2)

CHANGES:

### Fixed

- **irmin**
  - Fix performance issue in `Tree.length` (mirage/irmin#2258, @art-w)

- **irmin-pack**
  - Fix snapshot export when using lower layer (mirage/irmin#2257, @metanivek)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants