Add directory metadata #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| module type S = sig | ||
|
|
||
| include Ir_hum.S |
There was a problem hiding this comment.
Don't use private Ir_* interfaces in the public interface. That could break linking.
|
Would it make sense to add some tests for the metadata? As we don't really expose them I'm not sure what we can test that easily. |
A Node implementation can now expose additional metadata for each content item. The Git backend uses this to give the type of the file (normal, executable or symlink). Currently, this is only exposed via the private interfaces (not Irmin.BC).
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Node implementation can now expose additional metadata for each content item. The Git backend uses this to give the type of the file (normal, executable or symlink). This information is stored in the tree object, not the blob, so changing the content type doesn't work well.
Currently, this is only exposed via the private interfaces (not Irmin.BC/VIEW).