Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mem function to KV_RO #369

Merged
merged 8 commits into from Oct 8, 2016
Merged

Add mem function to KV_RO #369

merged 8 commits into from Oct 8, 2016

Conversation

yomimono
Copy link
Contributor

@yomimono yomimono commented Oct 2, 2016

Followon #368 ; this PR adds a mem function to KV_RO.

avsm and others added 5 commits September 15, 2016 13:31
@avsm
Port Irmin_mirage to Mirage3 PCLOCK interface
1e0c1ef 
This supersedes the old `CLOCK` interface with an explicit `PCLOCK`
that provides POSIX-style timespans
@avsm
rename git_store example to irmin_git_store to avoid module clash
7e8c217 
ocaml-git now defines a module called Git_store which causes
compilation to fail otherwise
@yomimono
mention irmin.mirage dependency on ptime in _tags, opam, pkg/META
1182433
@yomimono
add ptime to merlin
2c38dd6
@yomimono
add mem function to irmin_mirage
d90227b
@yomimono yomimono mentioned this pull request Oct 2, 2016
Merged
6 tasks
@yomimono
Copy link
Contributor Author

yomimono commented Oct 3, 2016

I'd prefer for an Irmin maintainer to take a look at this rather than merging myself. That said, I'm about to merge the mirage changes that necessitate this change, so if there are edits to this PR necessary it'd be nice to hear about them soon.

@samoht
Copy link
Member

samoht commented Oct 3, 2016

I've pushed some tentative CI fixes to your branch.

@yomimono
Copy link
Contributor Author

yomimono commented Oct 3, 2016

Thanks @samoht . I'll have a look at the current failures and see whether I can't get it to green.

@yomimono
Copy link
Contributor Author

yomimono commented Oct 3, 2016

Travis tests are failing on 4.03.0 because a reverse dependency, imaplet-lwt, has not been ported to ppx. ocaml/opam-repository#7565 notes that imaplet-lwt is not currently available for ocaml versions >= 4.03.

@samoht
Copy link
Member

samoht commented Oct 4, 2016

I have restarted the Travis jobs, let's see if that makes a difference.

@yomimono
Copy link
Contributor Author

yomimono commented Oct 4, 2016

imaplet-lwt's difficulties are deeper than I expected; I'm working on getting it buildable.

@yomimono yomimono merged commit 33022a5 into mirage:master Oct 8, 2016
yomimono added a commit that referenced this pull request Oct 8, 2016
@yomimono
Merge pull request #372 from yomimono/remove-id
6d2e1eb 
Remove `id` type, which will not be required by `mirage-types` 3. (followon #369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yomimono @samoht @avsm