This repository has been archived by the owner on Nov 28, 2017. It is now read-only.
Circular buffer #85
Merged
Circular buffer #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
We currently do not update the position of the last metadata position when writing the metadata to disk. This means that if you make multiple updates without rereading, the new metadata will always be written in the same area of the disk, thus causing apparent corruption if you're trying to read at the same time (the 'corruption' is detected by a CRC check, and is only transient). Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
The test was comparing the vg metadata before and after writing to disk, which fails as the location of the metadata changes. This fix removes the 'headers' field from the vg metadata, which contain the locations, before the comparison is made. Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
We now reread the metadata after writing it and look for the LV in the re-read data. Also, the test is tweaked so that it actually does wrap around in the metadata area. Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
|
Cool. Looks good. |
|
Thanks @simonjbeaumont |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the metadata area properly.