New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bounds checks and tests to the safe module #18

Merged

talex5 merged 3 commits into mirage:master from djs55:bounds-checks

May 18, 2016

Member

djs55 commented Apr 4, 2016

Check for:

negative starting offsets
starting offsets beyond size_sectors
finishing offsets beyond size_sectors

djs55 added 3 commits

April 4, 2016 20:47


          safe: check that the start sector is >= 0 and < size_sectors

05fdcc4

Signed-off-by: David Scott <dave@recoil.org>


          safe: check for writes beyond the end of the device

390abc5

Signed-off-by: David Scott <dave@recoil.org>


          safe: share more code between read and write

46ee98d

Signed-off-by: David Scott <dave@recoil.org>

coveralls commented Apr 4, 2016

Coverage remained the same at 73.641% when pulling 46ee98d on djs55:bounds-checks into 95f8260 on mirage:master.

talex5 merged commit 1b5ae7b into mirage:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment