Refactor CHANNEL types to be exception-less and use result
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove `read_stream` and `io_stream` as Lwt_stream is difficult to combine with error handling - remove `read_until` and only expose the line handling functions. I'm also considering moving the line-handling functions into a separate signature since most consumers of CHANNEL only want the buffering logic. - no more exceptions, just use `result` and propagate `FLOW.error` in return values.
4 tasks
hannesm
reviewed
Nov 23, 2016
| @@ -1,4 +1,4 @@ | |||
| version = "%%VERSION%%" | |||
| version = "%%VERSION_NUM%%" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_streamandio_streamas Lwt_stream is difficult tocombine with error handling
read_untiland only expose the line handling functions.I'm also considering moving the line-handling functions into a
separate signature since most consumers of CHANNEL only want the
buffering logic.
resultand propagateFLOW.errorin return values.