Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove camlp4 and update #71

Merged
merged 16 commits into from
Oct 27, 2016
Merged

Conversation

mor1
Copy link
Member

@mor1 mor1 commented Oct 10, 2016

Finally updating mirage-decks, including moving away from camlp4.
Not ready for merge yet.

@yomimono
Copy link
Contributor

I see you have "not done" in the commit messages still -- what's left to do here? I haven't looked closely at the changes but I see that your tests are passing, which seems like a good sign. Thanks for your work on this!

@mor1
Copy link
Member Author

mor1 commented Oct 17, 2016

When I last tested it, I think I'd botched something in the conversion so pages weren't rendering quite right. Should finish it off in the next week.

Cheers,

R.

On 16 Oct 2016, at 18:04, Mindy Preston notifications@github.com wrote:

I see you have "not done" in the commit messages still -- what's left to do here? I haven't looked closely at the changes but I see that your tests are passing, which seems like a good sign. Thanks for your work on this!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@mor1
Copy link
Member Author

mor1 commented Oct 22, 2016

Ok, I think that works now. Only light testing but the two topmost decks appear to be ok and that tests the index and both Reveal 2.4.0 and Reveal 2.6.2 which is basically everything.

If Travis passes I think this is ready for merge -- look ok to you @yomimono @avsm?

@yomimono
Copy link
Contributor

This is great! Thanks very much, @mor1 . :)

@yomimono yomimono merged commit 601b770 into mirage:master Oct 27, 2016
@yomimono
Copy link
Contributor

What do we need to do to rebuild http://decks.openmirage.org/ ?

@mor1
Copy link
Member Author

mor1 commented Oct 27, 2016

The site ought to rebuild as part of Travis completing testing the merge result successfully.
It should then reboot due to the post-merge hook in the deployment repo.
I'll check shortly...

@mor1
Copy link
Member Author

mor1 commented Oct 27, 2016

Hm, Travis has failed the DEPLOY=1 build -- looks like the name of the output .xen file changed. Will look into it.

@mor1 mor1 mentioned this pull request Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants