Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crypto and everything around it #179

Merged
merged 1 commit into from
Oct 27, 2016
Merged

Conversation

pqwy
Copy link
Contributor

@pqwy pqwy commented Oct 27, 2016

I was far, far too quick to release bits of this in the main repo, in hopes of avoiding dev pins for the supporting libs.

Turns out, the entire set of changes had variously wrong version constraints, and even some bad METAs floating around. 馃槶

Versions in this PR should work well together.

Note that it introduces yet another entropy package, mirage-entropy. That one obsoletes mirage-entropy-xen and mirage-entropy-solo5. If, by coincidence, this PR turns out to work, various tests floating around must remove mirage-entropy-xen from the list of packages they install.

@hannesm
Copy link
Member

hannesm commented Oct 27, 2016

you might want to remove mirage-entropy-xen and mirage-entropy-solo5 here, and add mirage-entropy... there's little chance this will succeed otherwise..

@hannesm
Copy link
Member

hannesm commented Oct 27, 2016

great work! 馃挴 馃憤 馃惈 馃憦 馃嵃

@pqwy
Copy link
Contributor Author

pqwy commented Oct 27, 2016

wait wait wait

@hannesm
Copy link
Member

hannesm commented Oct 27, 2016

and I suspect you'll have to sprinkle some --tests false around (see dbuenzli/topkg#79)

@pqwy
Copy link
Contributor Author

pqwy commented Oct 27, 2016

Guess what I'm doing right now?

@pqwy
Copy link
Contributor Author

pqwy commented Oct 27, 2016

The kinds of gut-wrenching errors that accidentally building tests leads to... This was unbelievable.

Builds on a pristine switch, under 4.02.3 and 4.03.0. shudders

@hannesm hannesm merged commit 1002cc5 into mirage:master Oct 27, 2016
@pqwy pqwy deleted the breakage branch October 27, 2016 22:39
@avsm
Copy link
Member

avsm commented Oct 28, 2016

Thanks @pqwy!

avsm added a commit to avsm/mirage that referenced this pull request Oct 28, 2016
avsm pushed a commit to avsm/mirage-dev that referenced this pull request Jan 22, 2017
Update usage help command in README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants