Tcpip.4.1.0 #37
Merged
Tcpip.4.1.0 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts parts of cc1aac2, while: a) keeping the lru>=0.3.0 compatibility b) using in the record a non-mutable field to a ref lru.t (previously: mutable x : Lru.t ref; now x : Lru.t ref) - to satisfy the SUBTABLE interface
|
tcpip-4.1.0 looks merged now, so +1 for merging this one |
|
I don't know much about this code, but this PR looks reasonable to me. |
talex5
approved these changes
Feb 17, 2020
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Feb 18, 2020
CHANGES: - support tcpip 4.1.0, which Ipv4.Fragments interface changed from LRU.M to LRU.F - Mirage_nat_lru uses as well a LRU.F again - breaking: Nat_packet.of_ipv4_frame / of_ethernet_frame output a pair of `Fragments.t * (t option, error) result` - all in mirage/mirage-nat#37 by @hannesm
mgree
pushed a commit
to mgree/opam-repository
that referenced
this pull request
Feb 19, 2020
CHANGES: - support tcpip 4.1.0, which Ipv4.Fragments interface changed from LRU.M to LRU.F - Mirage_nat_lru uses as well a LRU.F again - breaking: Nat_packet.of_ipv4_frame / of_ethernet_frame output a pair of `Fragments.t * (t option, error) result` - all in mirage/mirage-nat#37 by @hannesm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this depends on the not-yet-released tcpip 4.1.0 which changes the type of Fragments.Cache.t
in addition, this as well removes some unnecessary dependencies from mirage-nat
and reverts the change from Lru.F.t to Lru.M.t (for the overall reasons mentioned in mirage/mirage-tcpip#423 // mirage/qubes-mirage-firewall#93)
//cc @talex5 @xaki23