This repository has been archived by the owner on Oct 18, 2020. It is now read-only.
Add support for OCaml 4.08 #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this is a relief! I was a little worried about the impact of the new autoconf changes. I'll try this out over the next few days |
|
I'm going ahead and merging this as it cant cause any harm while the new ocaml betas are being rolled :-) |
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Feb 19, 2019
supports forthcoming dune support as part of mirage/mirage#969: * Add support for OCaml 4.08 (mirage/mirage-platform#206 by @anmonteiro) * `libxenasmrun.a` is symlinked in the ocaml directory in order to be able to use ocamlopt's `-runtime-variant` option. * Expose flags through files as well as pkg-config (mirage/mirage-platform#205 by @TheLortex). Instead of pkg-config, one can use the following files to get compilation flags: * mirage-xen-ocaml/libs * mirage-xen-ocaml/cflags * mirage-xen-posix/minios-cflags * mirage-xen-posix/minios-libs * mirage-xen-posix/posix-cflags * mirage-xen-posix/posix-libs With dune this allows us to write `%{lib:mirage-xen-posix:posix-libs}` to get the flags instead of having a script invoking `pkg-config mirage-xen-posix --libs`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still very early days, but I thought I'd get a head start to see how hard it would be to also support OCaml 4.08.X in
mirage-xen-ocaml.Turns out not very hard. Apart from
asmrunandbyterunbeing merged into a single directory upstream, no other changes seem to be necessary.Word of caution: I haven't actually built a unikernel yet with these changes, given that so many dependencies aren't ready for 4.08 yet.