This repository has been archived by the owner on Oct 18, 2020. It is now read-only.
Fix flags generation. #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this supersedes #208 since it also fixes the system compiler with the rename to libasmrunxen -- is there a test for that in the CI atm? |
avsm
approved these changes
May 29, 2019
|
Does this fix mirage-xen compilation in the duniverse @TheLortex ? Might be worth putting this branch as a pin in opam-overlays to see if it fixes mirage-xen there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag file generation was broken for some distros such as Ubuntu: the concatenation of outputs was missing a space between flags.
Now the
libsfile is intended to be used directly as an option to ocamlopt. Finallylibxenasmrun.ais renamed tolibasmrunxen.aand we don't need to install it in the ocaml directory anymore.