GUId mvar, see #33 #37
Conversation
There was a problem hiding this comment.
this looks good to me. it implements a larger chunk of the gui protocol for mirageos + qubes -- which makes it usable from the mirage-framebuffer (iirc) library?
if others are fine (and someone checked that existing applications, as well as mirage-framebuffer are working with these changes), I'd suggest to merge sooner than later -- we can always advance the qubes (gui) support in subsequent PRs.
| keycode : int32; | ||
| } | ||
|
|
||
| (** Dom0 -> VM *) | ||
| (* https://github.com/drinkcat/chroagh/commit/1d38c2e2422f97b6bf55580c9efc027ecf9f2721 *) | ||
| [%%cstruct | ||
| type msg_keypress = { | ||
| ty : uint32_t; (* TODO *) | ||
| ty : uint32_t; |
There was a problem hiding this comment.
| ty : uint32_t; | |
| ty : uint32_t; (* TODO *) |
unintentional change!?
There was a problem hiding this comment.
Hmm, it was intentionally put there because I'm not 100% sure what ty means in this case, but I don't know if it should be in this PR :-/
|
Now that the |
Trying this again,
see #32
and #33
ping @yomimono @hannesm @reynir