RExec.connect: handle protocol version negotiation #57
Conversation
|
The "fail if other ends wants version 1" looks fine to me; but I'm not a big fan of the conditionally print a debug message -- and would either use a warning there, or keep the old code (an info message printing the remote version). |
|
It's not really a warning - there's nothing wrong with the other end offering a newer version. How about an |
|
The old code was wrong in its log message, though, in the case of the other end wanting to use protocol version 3. Then it would log us using protocol version 3 even though we send protocol version 2 thereby forcing the protocol version to 2. |
|
The new commit unconditionally logs the protocol version negotiation in both places. |
|
that looks good - though I'd condense the two |
|
Yes, I'll fix it up. The log message still says "newer" even though that's not necessarily true. |
reynir
force-pushed
the
qrexecv3-future-compat
branch
from
446c859
to
0e3525a
Compare
reynir
force-pushed
the
qrexecv3-future-compat
branch
from
0e3525a
to
7bb6c85
Compare
CHANGES: - RExec: being future compatible, and negotiate protocol version 2 (mirage/mirage-qubes#56 mirage/mirage-qubes#57 @reynir) - Remove Utils module (mirage/mirage-qubes#58 @hannesm) - RExec: close connection with peer on unknown messages, instead of raising an exception (mirage/mirage-qubes#61 @reynir)
Continuation of #56.
Adds debug message the other place where protocol version is negotiated. In the case of version > 2 it would work without this patch. It fails if the other end wants to use version 1 for good measure.