Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Implement qrexec protocol version 3 #60

Merged
merged 6 commits into from
Sep 7, 2022
Merged

Conversation

reynir
Copy link
Member

@reynir reynir commented Nov 25, 2020

This is untested.

It implements changes necessary to implement qrexec protocol version 3, which includes:

  • Backwards compatibility with version 2,
  • Much larger data chunk size,
  • New trigger_service_params3 which allows for longer target domain names and service names

I need to review the code again later tonight. I have a Qubes 4 laptop without qrexec v3 I can test with (until I upgrade).

@reynir reynir force-pushed the qrexecv3 branch 2 times, most recently from b250429 to 960620b Compare November 25, 2020 15:24
@palainp
Copy link
Member

palainp commented Sep 5, 2022

So far I can confirm that the current master for qubes-mirage-firewall is compiling and booting fine and that the [qubes.rexec] client connected, other end wants to use protocol version 3, continuing with version 2 message isn't anymore in the logs (with [qubes.rexec] client connected, using protocol version 3 instead).

@hannesm
Copy link
Member

hannesm commented Sep 7, 2022

IMHO this is fine to merge & release: @reynir and @palainp implemented it, @palainp reports it works for him. The code looks fine. Any objections?

@reynir
Copy link
Member Author

reynir commented Sep 7, 2022

My only concern is that the qrexec version 2 path isn't tested, but considering how long it's been since version 3 was introduced I think it's only a minor concern. I would be okay with merging this.

@hannesm hannesm merged commit 6d92327 into mirage:main Sep 7, 2022
hannesm added a commit to hannesm/opam-repository that referenced this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants