New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate should return string rather than Cstuct.t #388
Conversation
Previously building these examples would fail with the error ``` Error: This expression has type int -> Cstruct.t but an expression was expected of type int -> string Type Cstruct.t is not compatible with type string make[1]: *** [build] Error 1 ```
Thank you for your PR! The recent randomconv.0.2.0 release changed the expected type from I would say the preferred way forward is to set an upper bound on randomconv<0.2.0 for now. |
This reverts commit d11689b. Reverting this as per Reynir's suggestions in mirage#388 (comment)
Recent randomconv.0.2.0 release changed the expected type from Cstruct.t to string in anticipation of an upcoming mirage-crypto release that brings a cstruct->string overhaul. This change sets an upper bound on randomconv<0.2.0 until that work is complete.
@reynir Thanks for explaining. I've reverted the original commit, added the upper bound you suggested and checked the kernel's build without issue, so you can squash them or just cherry pick the final commit if you want the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is great. One thing though: The ~max
argument to Mirage.package
is exclusive meaning ~max:"0.1.3"
is <"0.1.3"
. I forget this all the time, and the documentation is not-so-helpfully referring to some Functoria documentation (I will open an issue on that).
Max is exclusive. Co-authored-by: Reynir Björnsson <reynir@reynir.dk>
Max is exclusive. Co-authored-by: Reynir Björnsson <reynir@reynir.dk>
Max is exclusive. Co-authored-by: Reynir Björnsson <reynir@reynir.dk>
Thanks a lot! |
Co-authored-by: "O. Emmerson" <oemmerson@gmx.com> Co-authored-by: Reynir Björnsson <reynir@reynir.dk>
Previously building these examples would fail with the error