IP: add configured_ips : t -> prefix list #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
changed the title
|
This PR has been updated, |
|
This requires the ipaddr package as proposed in ocaml/opam-repository#25919 -- so we'll need to wait for that being merged before the CI in here will succeed. |
reynir
approved these changes
May 23, 2024
Mark get_ips as deprecated, use configured_ips across this package. Also carry the type equality for 'type prefix' across.
|
tests were failing, there's a discrepancy in ipv6 with having both prefix and address list. I changed the address list to contain Ipaddr.Prefix.t now -- this means both the IP address and the netmask is stored in there. The tests pass. IMHO good to merge. We'll need to do an IPv6 deep dive at some point in any case. |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
May 29, 2024
CHANGES: * adapt to mirage-vnetif 0.6.2 changes (mirage/mirage-tcpip#517 @hannesm) * Add `type prefix = Ipaddr.Prefix.t` and `IP.configured_ips : t -> prefix` to the IP layers (mirage/mirage-tcpip#516 @hannesm) * Mark `get_ips` as deprecated, use `configured_ips` instead (mirage/mirage-tcpip#516 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.