Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling of warnings in config.ml #621

Closed
hannesm opened this issue Oct 15, 2016 · 1 comment
Closed

Allow disabling of warnings in config.ml #621

hannesm opened this issue Oct 15, 2016 · 1 comment

Comments

@hannesm
Copy link
Member

hannesm commented Oct 15, 2016

As suggested by @gasche in abbysmal/Canopy#66 -- in this specific case warning 42 is signalled due to Syndic exposing several constructors with the same name from a single module. There can be nothing done in Canopy to avoid this problem. It would be great to be able to specify in config.ml which warnings to suppress.

@hannesm
Copy link
Member Author

hannesm commented Oct 15, 2016

Further note from @gasche in the Canopy issue, indicating that we should maybe not enable warning 42 at all:

My mental model is that few people would enable warning 42: it used used by either skeptics that don't believe in type-based disambiguation, or by people that want to guarantee that their code remains compatible with ocaml < 4.01. As a a library author, I would not accept making a breaking change to cater to the people using it.

yomimono added a commit that referenced this issue Oct 24, 2016
disable warning 42; fixes #621; agreeing with @gasche argument; no 4.01 compat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant