Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce the right minimum OCaml version #696

Closed
3 tasks
avsm opened this issue Nov 21, 2016 · 4 comments
Closed
3 tasks

enforce the right minimum OCaml version #696

avsm opened this issue Nov 21, 2016 · 4 comments
Milestone

Comments

@avsm
Copy link
Member

avsm commented Nov 21, 2016

We need to enforce a proper minimum OCaml version in MirageOS 3 before it comes out of beta:

  • we no longer test <4.03 on Travis so if it is 4.02 then we need to add it back
  • -ocaml-version-checkin check_ocaml_version still asks for 4.02.3+
  • the opam files also require 4.02.

So if we leap to 4.03 as the minimum version we need to fix up the ocaml version checks, and if we stay on 4.02 we need to restore test cases. Personally I am in favour of shifting up to 4.03 given the rapid pace of OCaml releases recently.

CC #695 also for 4.02 compilation fixes

@hannesm
Copy link
Member

hannesm commented Nov 21, 2016

for the record, I usually like to keep backwards compatibility if it is not too much of a pain. but considering the OCaml releases, I'd be in favour to drop 4.02 (and 4.03 asap). I don't see a reason for MirageOS (due to its small deployment base) to require support for OCaml versions shipped with debian/ubuntu/etc. If we do, we should push them to package OCaml more timely (I had some success in debian, thanks to @infinity0).

Looking from a security angle:

Other libraries, such as tls/nocrypto/cohttp/... might want to retain compatibility with 4.02.3, 4.01, ...

@avsm
Copy link
Member Author

avsm commented Nov 21, 2016

I don't see a reason for MirageOS (due to its small deployment base) to require support for OCaml versions shipped with debian/ubuntu/etc.

Yes I don't believe that the distribution packaging is much of a concern now -- retaining support for OPAM 1.2.2 (which is mostly packaged now) is more important so that there is a bootstrap procedure on those operating systems. Docker uses quite a few MirageOS libraries and types, so if @djs55 @samoht @yomimono could confirm that a minimum 4.03 is now ok for those deployments, that would be helpful in making the decision.

@djs55
Copy link
Member

djs55 commented Nov 21, 2016

I think I'm using 4.03 everywhere now so a minimum of 4.03 is fine by me.

@hannesm hannesm added this to the mirage 3.0.0 milestone Nov 22, 2016
@hannesm hannesm mentioned this issue Nov 25, 2016
@hannesm
Copy link
Member

hannesm commented Nov 27, 2016

as a comment here, I removed the ocaml version check in #703. This is off-topic for the mirage tool. We can instead use available in the opam file for mirage, and also emit available for the opam files mirage generates.

@mato mato closed this as completed in #703 Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants