Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mirage 3.x] Port to new Mirage/Xen platform stack #1183

Merged
merged 7 commits into from Oct 24, 2020

Conversation

mato
Copy link
Contributor

@mato mato commented Jul 24, 2020

This adapts the mirage front-end tool to the new Mirage/Xen platform stack (see #1159).

User-visible changes:

  • .xe (Xenserver) filegeneration has been removed, I have no way to test this.
  • "Unknown" argument filtering in Bootvar / argv has been removed, this was causing problems and I do not know of any users apart from Qubes OS where this can be solved differently, see comments in Xen PVH: Third time lucky #1159.

Note that Xen unikernels now include a dummy Solo5 manifest to keep the rest of the build system and Solo5 layers happy; this does not contain any devices as they are not required and Xen device naming does not follow Solo5 requirements.

@mato
Copy link
Contributor Author

mato commented Jul 24, 2020

Also note that I have not updated the libvirt XML generation code which is probably wrong; needs someone with a libvirt + Xen setup to test this.

@mato mato mentioned this pull request Jul 24, 2020
7 tasks
@hannesm hannesm changed the base branch from 3.8 to 3 October 18, 2020 17:47
@hannesm
Copy link
Member

hannesm commented Oct 20, 2020

I retargeted the 3 branch of this repository (3.7 and 3.8 no longer exist now).

I pushed a commit to not link the tcpip.xen sublibrary anymore -- in mirage-xen 6.0.0 the checksum C code is provided by mirage-xen itself.

mato and others added 3 commits October 23, 2020 10:31
This adapts the `mirage` front-end tool to the new Mirage/Xen platform
stack (see mirage#1159).

User-visible changes:

- `.xe` (Xenserver) filegeneration has been removed, I have no way to
test this.
- "Unknown" argument filtering in `Bootvar` / `argv` has been removed,
this was causing problems and I do not know of any users apart from
Qubes OS where this can be solved differently, see comments in
mirage#1159.

Note that Xen unikernels now include a dummy Solo5 manifest to keep the
rest of the build system and Solo5 layers happy; this does not contain
any devices as they are not required and Xen device naming does not
follow Solo5 requirements.
Thus, tcpip.xen is not needed to be linked anymore.
@hannesm
Copy link
Member

hannesm commented Oct 23, 2020

I rebased on top of the 3 branch, and adjusted the version constraints for implementation packages (mirage-net-xen etc.) - which are now released to opam-repository. I expect the CI building mirage-skeleton to succeed, and this being ready to be merged and released (pending a changes entry).

@mato
Copy link
Contributor Author

mato commented Oct 23, 2020

I have tested tutorial/hello, device-usage/network and applications/static-website-tls from mirage-skeleton manually with nothing except a pin of mirage to this branch, and all builds and runs fine on Debian buster, Xen 4.11.4. The test unikernels from ocaml-vchan also work.

So, we're good to go for merging and releasing! 🎉

These two things are hardly related, keep them separate
@mato
Copy link
Contributor Author

mato commented Oct 24, 2020

Reviewed and tested @hannesm changes through 5ac2758, looks good.

mirage does not contain any tests, avoid unneccessary rebuilds
@hannesm hannesm merged commit 348f529 into mirage:3 Oct 24, 2020
@mato mato deleted the 3.8+xen-pvh-via-solo5 branch October 27, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants