support for conduit 5 #1246
Merged
support for conduit 5 #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Oct 20, 2021
…me (3.10.6) CHANGES: - Adapt to conduit 5.0.0 API (and dns 6.0.0) @hannesm mirage/mirage#1246 - Avoid deprecated Fmt functions @hannesm mirage/mirage#1246
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the conduit resolver now gets a PCLOCK in the functor, and
vis changed to take an optionalnameserversargument. The default nameserver is already in dns-client.mirage, no need to duplicate the IP address in MirageOS.Furthermore, with dns-client 6.0.0 we use (a) happy-eyeballs (b) DNS-over-TLS. This means the IPv6 address of anycast.uncensoreddns.org and IPv4 address thereof are tried in order.
TL;DR: best not to pass a resolver down the line.