fix opam-monorepo issue with Ocaml5+ #1409
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear developers,
This PR should solve tarides/opam-monorepo#340 and permits to compile mirage unikernels with Ocaml5+.
The underlying issue was the
ocaml
package marked as opam-provided and thus removed from dependencies at https://github.com/tarides/opam-monorepo/blob/9cc963ce7bc91592a301feca1e2238bc17448bd8/lib/opam_solve.ml#L114 (This can be seen inside the solver: ocaml-opam/opam-0install-solver#47). Therefore, as https://github.com/ocaml/opam-repository/blob/master/packages/base-domains/base-domains.base/opam have a dependency list which containsocaml
ORocaml-variants
, leave the solver only withocaml-variants
if we removeocaml
.For the time being I moved ocaml to the
Monorepo
scope, this is why it now appears as monorepo in the test files, but unsure if that the best move, comments are more than welcome!