use \033 instead of \e for ansi escape sequences #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if someone with a linux machine and/or macos could confirm that this works fine for them, please report here. for me, on FreeBSD this avoids printing \e[2m, and instead prints the text in gray. |
|
tested on a linux VM, works great! |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Nov 20, 2023
… (4.4.1) CHANGES: - Document exit codes in `--help` (mirage/mirage#1485 @hannesm) - Avoid dependency on environment variable (removing MIRAGE_LOGS mirage/mirage#1484 @hannesm) - BUGFIX: dune.config mark "dist" as data-only-dir to allow config.ml being compiled (mirage/mirage#1475 @memst) - Allow git 3.14 (mirage/mirage#1474 @hannesm) - Default to best-fit allocation (mirage/mirage#1473 @hannesm) - FEATURE: Add a key "--delay" to all unikernels (mirage/mirage#1472 @hannesm, fixes mirage/mirage#1468) - Fix Unix target dune rule (add a deps) (mirage/mirage#1469 @hannesm) - Optionally pass tcp in direct_stackv4v6, static_ipv4v6, generic_stackv4v6 (mirage/mirage#1467 @hannesm) - FEATURE: Support mirage version indication in first line of config.ml: (* mirage >= 2.3.4 & < 5.0.0 *) (mirage/mirage#1466 @hannesm, fixes mirage/mirage#1381) - Use \033 instead of \e in generated Makefile (fixes the output on non-Linux systems mirage/mirage#1464 @hannesm) - Adapt to mirage-logs 2.0.0 (mirage/mirage#1460 @hannesm) - Allow version 0.8.0 of solo5 (mirage/mirage#1432 mirage/mirage#1490 @hannesm @palainp)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in https://stackoverflow.com/questions/54039983/print-bold-or-colored-text-from-makefile-rule