Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some functions, also remove dependency on astring (replace code to use Stdlib String module) #1486

Merged
merged 9 commits into from
Nov 20, 2023
Merged

Remove some functions, also remove dependency on astring (replace code to use Stdlib String module) #1486

merged 9 commits into from
Nov 20, 2023

Commits on Nov 12, 2023

  1. remove functions not needed by mirage4 anymore

    @hannesm
    hannesm committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    672bd30 View commit details
    Browse the repository at this point in the history

  2. Functoria tool: use the Log source defined in the module

    @hannesm
    hannesm committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    29fc399 View commit details
    Browse the repository at this point in the history

  3. mirage: remove astring dependency

    @hannesm
    hannesm committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    63dee2a View commit details
    Browse the repository at this point in the history

  4. Move logs dependency to the implementation part

    @hannesm
    hannesm committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    d66cc4f View commit details
    Browse the repository at this point in the history

  5. revise ccm_block to not use astring

    @hannesm
    hannesm committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    787d8b6 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. remove astring from dep of mirage-impl-block (as requested by @reynir)

    @hannesm
    hannesm committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    4d17205 View commit details
    Browse the repository at this point in the history

  2. use String.map in mirage_impl_kv, as requested by @reynir

    @hannesm
    hannesm committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    c82a59e View commit details
    Browse the repository at this point in the history

  3. simplify "file", since it is constructed by Static_<to_lower <whateve… 

    …r>>, no

need to call another String.lowercase_ascii (since Foo.ml and foo.ml both define
module Foo).
    @hannesm
    hannesm committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    fc010c4 View commit details
    Browse the repository at this point in the history

  4. fix opam-lint: mirage-runtime depends on ipaddr (but only mirage-runt… 

    …ime.network depends on it at runtime)
    @hannesm
    hannesm committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    63f35bb View commit details
    Browse the repository at this point in the history