Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme #508

Merged
merged 2 commits into from
Mar 14, 2016
Merged

Update Readme #508

merged 2 commits into from
Mar 14, 2016

Conversation

amirmc
Copy link
Contributor

@amirmc amirmc commented Mar 7, 2016

Edited initial paragraph. Commented out the other material and
instead pointed at the main website.

Edited initial paragraph. Commented out the other material and
instead pointed at the main website.
@amirmc
Copy link
Contributor Author

amirmc commented Mar 7, 2016

I left a bunch of stuff commented out. Happy to remove it but wanted to check first.

build steps (from JavaScript to Xen unikernels), and this complexity is wrapped
up in the tool.

To work with Mirage, you'll need the following prerequisites installed:

* a working [OCaml](http://ocaml.org) compiler (4.01.0 or higher).
* a working [OCaml](http://ocaml.org) compiler (4.02.1 or higher).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.02.3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.02.2 should be fine!? (that's the lower bound of ppx sexp)...

@avsm
Copy link
Member

avsm commented Mar 7, 2016

a short thing about the docker run -it unikernel/mirage container would also be useful. I'll be maintaining that moving forward.

@hannesm
Copy link
Member

hannesm commented Mar 7, 2016

shouldn't docker instructions be kept in some (to-be-written) wiki/install-docker? there shouldn't be the impression that MirageOS depends on docker...

@amirmc
Copy link
Contributor Author

amirmc commented Mar 7, 2016

I think it's fine to mention the Docker images since the aim is to maintain them. If it makes it quicker to get started (for those who already have Docker) then it's worth highlighting them.

@avsm
Copy link
Member

avsm commented Mar 7, 2016

shouldn't docker instructions be kept in some (to-be-written) wiki/install-docker?

just as a "quickstart" in the README is fine, along with manual install instructions. The OPAM PPAs are getting increasingly difficult to maintain and these are the ones used in bulk builds, so most likely to work...

@avsm
Copy link
Member

avsm commented Mar 7, 2016

re: 4.02.2 vs 4.02.3, again only the latest point release is tested, so best to recommend that as the lower bound

@avsm
Copy link
Member

avsm commented Mar 7, 2016

also need to do a quick sweep for other compiler version deps -- there is a version check on opam in mirage but not sure about compiler version. @samoht may remember

@samoht
Copy link
Member

samoht commented Mar 14, 2016

I've just added more checks to the tool (mirage-types, mirage-types-lwt, and OCaml version) so should be better. Merging now.

samoht added a commit that referenced this pull request Mar 14, 2016
@samoht samoht merged commit fa0dd45 into mirage:master Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants