Convert build to jbuilder #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Scott <dave@recoil.org>
Previously we used the internal name Protocol_9p_info which is nolonger available during a jbuilder build. Signed-off-by: David Scott <dave@recoil.org>
Everything inside the library is packed, so the module must be opened. Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Note this uses the public module names rather than internal ones. Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
- no more depopts - use `jbuilder` directly from `opam` for fine-grained control of targets; `make` builds everything Signed-off-by: David Scott <dave@recoil.org>
- protocol-9p-unix -> protocol-9p - protocol-9p-tool -> protocol-9p & protocol-9p-unix Signed-off-by: David Scott <dave@recoil.org>
This mirrors the .travis.sh configuration. Signed-off-by: David Scott <dave@recoil.org>
It's currently impossible to diagnose failures under CI since the logs are missing. Signed-off-by: David Scott <dave@recoil.org>
This remains compatible with Lwt < 3.0.0 but we now require Lwt 2.7.1. This prevents a test failure when building against Lwt 3.0.0: since `bind` returns a promise, we were calling `listen` concurrently which fails with `EINVAL`. Signed-off-by: David Scott <dave@recoil.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opampackages:protocol-9pprotocol-9p-unixandprotocol-9p-tooldepoptsconfigurestep to detectlambda-termprotocol-9p-unixis now packed withinProtocol_9p_unix