Server: call receive_cb on initial Attach
#39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch we were in an inconsistent situation where the first `attach` was handled magically by the server functor, while all subsequent `attach` requests had to be handled by the user module. This led to the initial `root_fid` being special-cased. This patch requires the user module to handle all `attach` requests, making it easier for the user module to maintain a table of active fids (i.e. no need for special-casing the `root_fid`) Signed-off-by: David Scott <dave.scott@unikernel.com>
djs55
added a commit
that referenced
this pull request
Dec 9, 2015
Server: call `receive_cb` on initial `Attach`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch we were in an inconsistent situation where the first
attachwas handled magically by the server functor, while all subsequentattachrequests had to be handled by the user module. This led to theinitial
root_fidbeing special-cased.This patch requires the user module to handle all
attachrequests, makingit easier for the user module to maintain a table of active fids (i.e.
no need for special-casing the
root_fid)Signed-off-by: David Scott dave.scott@unikernel.com