lofs: respect msize in read
#41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some clients will negotiate an `msize` of (e.g.) 16384 and then issue a `read` with `count=65536`, and then complain when they receive that many bytes back. This patch makes `lofs` respect the negotiated `msize` in `read` by returning as many bytes as possible, up to the `msize`. Signed-off-by: David Scott <dave.scott@unikernel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clients will negotiate an
msizeof (e.g.) 16384 and then issue areadwithcount=65536, and then complain when they receive thatmany bytes back. This patch makes
lofsrespect the negotiatedmsizein
readby returning as many bytes as possible, up to themsize.Signed-off-by: David Scott dave.scott@unikernel.com