-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie/Response/Request could use some functional setters #38
Comments
I've been playing with avsm/ocaml-lens to see if those are better getter/setters instead of fieldslib. But yes, this is a good point. Fieldslib isn't a bad solution either. |
It's no longer abstract in the interface in 0.9.12, since there are no invariants protected by the creation function. |
I changed my mind and exposed a bunch of fieldslib implementations of request/response and cookie in 0.9.12 |
Thanks, this is deal. Now updating a cookie within a request is much easier. |
For example updating the expiration of
Set_cookie_hdr.t
value is not easy. I have similar annoyances withRequest/Response
and headers. Easiest way to fix this is to add the fieldslib dependency andwith fields
to the types. Or just add the boilerplate if a new dependency is a no-no.The text was updated successfully, but these errors were encountered: