Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookie expiration needs to be implemented #70

Closed
rgrinberg opened this issue Dec 22, 2013 · 1 comment
Closed

cookie expiration needs to be implemented #70

rgrinberg opened this issue Dec 22, 2013 · 1 comment

Comments

@rgrinberg
Copy link
Member

I need this functionality myself, but from the source code:

(* We need a non-Unix date/time implementation to support other expiration types *)

What's the reasoning why Unix cannot be used? Is it for mirage compatibility?. As a compromise can we implement max-age instead? I'd like to have max-age anyway.

avsm added a commit that referenced this issue Jan 3, 2014
@avsm
Copy link
Member

avsm commented Jan 3, 2014

We can't depend on the Unix module in the core parsing library, as it's also used in embedded contexts such as openmirage.org. However, we could just expose it as a string and leave it to the caller of the library to provide a well-formed date. I've added support for max-age in #73, so that'll be in 0.9.15

@avsm avsm modified the milestone: 1.0 Stable API Nov 9, 2014
@avsm avsm added the Feature label Nov 9, 2014
@yomimono yomimono closed this as completed Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants