Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Better documentation for the Header module #75

Closed
protz opened this issue Jan 5, 2014 · 1 comment · Fixed by #78
Closed

[doc] Better documentation for the Header module #75

protz opened this issue Jan 5, 2014 · 1 comment · Fixed by #78

Comments

@protz
Copy link

protz commented Jan 5, 2014

Hi,

I've been bitten bit this, but I didn't waste too much time since I suspected what was going on :-).

The header module should probably mention that the header names are lowercase. Servers usually write headers as "Location: ", so that's what I intuitively wrote. Alternatively, the implementation should first lowercase the parameter passed to function such as Header.get.

Cheers,

~ jonathan

@avsm
Copy link
Member

avsm commented Jan 5, 2014

The header names should be case-insensitive, so this is more than a documentation fix. I'll just force everything field in the header key to be lowercase.

On 5 Jan 2014, at 17:28, Jonathan Protzenko notifications@github.com wrote:

Hi,

I've been bitten bit this, but I didn't waste too much time since I suspected what was going on :-).

The header module should probably mention that the header names are lowercase. Servers usually write headers as "Location: ", so that's what I intuitively wrote. Alternatively, the implementation should first lowercase the parameter passed to function such as Header.get.

Cheers,

~ jonathan


Reply to this email directly or view it on GitHub.

@avsm avsm closed this as completed in #78 Jan 9, 2014
@avsm avsm modified the milestone: 1.0 Stable API Nov 9, 2014
mseri added a commit to mseri/ocaml-cohttp that referenced this issue Jun 16, 2022
Add support for async and core >= v0.9.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants