Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cohttp-server-lwt bind #298

Merged
merged 3 commits into from Apr 3, 2015
Merged

Fix cohttp-server-lwt bind #298

merged 3 commits into from Apr 3, 2015

Conversation

dsheets
Copy link
Member

@dsheets dsheets commented Apr 1, 2015

I also put an interface on Cohttp_lwt_unix_net and left doc comments noting it as private. I believe it is intended to be private but... maybe not?

@dsheets dsheets mentioned this pull request Apr 1, 2015
Closed
@samoht
Copy link
Member

samoht commented Apr 1, 2015

If it is really private, can you also update the _oasis file to move it into some InternalModules?

@dsheets
Copy link
Member Author

dsheets commented Apr 1, 2015

I don't think it actually is private any more. If you want to use Cohttp_lwt.Make_client with alternative IO, Request, or Response but not Net then it would be handy to have it around. I updated the branch but I'm still tracking down the 4.01.0 camlp4 syntax error.

@dsheets
Copy link
Member Author

dsheets commented Apr 1, 2015

times out on async_extra

@avsm avsm merged commit d93c4ab into mirage:master Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dsheets @samoht @avsm