Fix 204 beavior #375
Merged
Fix 204 beavior #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
204's should not return a transfer encoding
Do not add transfer encoding if response code does not allow it
| let headers = Header.add_transfer_encoding res.headers res.encoding in | ||
| let headers = | ||
| if allowed_body res | ||
| then Header.add_transfer_encoding res.headers res.encoding |
There was a problem hiding this comment.
shouldn't this check to see if the response already has a Transfer-encoding header and not override it if so?
There was a problem hiding this comment.
Probably. I'll take a look at this separately since this PR doesn't change this aspect of the behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @edwintorok