Move all lwt signatures to Cohttp_lwt_s #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is likely to need mirage-http fixed but I'd prefer to address that along with #396 |
|
Need to check that |
This module is now exposed as S from inside Cohttp_lwt and is named as it would be if we were manually packing the library anyway.
Minimizes the amount of breakage
|
@samoht I've added some aliases to preserve compatibility. |
rgrinberg
added a commit
that referenced
this pull request
Jul 25, 2015
Move all lwt signatures to Cohttp_lwt_s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid duplicating the signatures in Cohttp_lwt.ml{,i} like
Cohttp