Handle empty cookie components gracefully #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This looks right to me. Did you run into these malformed cookies in the wild? |
|
@avsm Yes, we did, unfortunately. It is a bit surprising because our code was running fine until a wave of these invalid cookies came in and took down the system. |
|
Thanks for the PR! I'll cut a quick release. |
|
Thanks @avsm, much appreciated! |
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Apr 9, 2019
CHANGES: - cohttp: handle empty cookie components gracefully without raising an exception (mirage/ocaml-cohttp#663 @martinslota)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.