Async client: do not read body if there is none #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Responses with code 204 (No content) and 304 (Not modified) do not have bodies. They can come with no Content-Length header, in which case the transfer encoding is inferred as `Transfer.Unknown`. When trying to read the nonexistent body, it would do so using `Transfer_io.Unknown.read`, which attempts to read until EOF, which can cause hangs. There is some logic in `Response.has_body` to determine if we should attempt to read a body at all. This was hooked in the `Lwt` backend but not in the `Async` one. Closes mirage#666
|
Not sure how to write an automated test for this, but this fixes the 204 & 304 cases in #666. |
|
This lgtm, thanks! |
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Aug 18, 2019
…c, cohttp-top, cohttp-lwt-unix and cohttp (2.3.0) CHANGES: - use conduit-mirage instead of mirage-conduit, which was renamed upstream in conduit. The minimum OCaml version supported for conduit-mirage is now OCaml 4.07 and higher. (mirage/ocaml-cohttp#672 @avsm) - remove deprecation warnings in OCaml 4.08.0 using stdlib-shims (mirage/ocaml-cohttp#672 @avsm) - async: do not read body if none is present (mirage/ocaml-cohttp#671 @emillon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responses with code 204 (No content) and 304 (Not modified) do not have
bodies. They can come with no Content-Length header, in which case the
transfer encoding is inferred as
Transfer.Unknown. When trying to readthe nonexistent body, it would do so using
Transfer_io.Unknown.read,which attempts to read until EOF, which can cause hangs.
There is some logic in
Response.has_bodyto determine if we shouldattempt to read a body at all. This was hooked in the
Lwtbackend butnot in the
Asyncone.Closes #666