Use package core_unix instead of core, to prepare for core release 0.15. #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arseniy Alekseyev <aalekseyev@janestreet.com>
|
Thanks! I am also going to backport this to the 2.x branch |
mseri
added a commit
to mseri/opam-repository
that referenced
this pull request
Dec 15, 2021
…wt-unix, cohttp-lwt-jsoo and cohttp-async (2.5.6) CHANGES: - cohttp-async: use package core_unix instead of core, to prepare for core release 0.15 (aalekseyev mirage/ocaml-cohttp#791 - backport) - cohttp-mirage: fix deprecated fmt usage (tmcgilchrist mirage/ocaml-cohttp#791 - backport)
bcc32
added a commit
to bcc32/ocaml-cohttp
that referenced
this pull request
Mar 28, 2022
Similar to mirage#791, but for the examples directory, which is a dependency of @runtest for cohttp-async. Signed-off-by: Aaron L. Zeng <me@bcc32.com>
bcc32
added a commit
to bcc32/ocaml-cohttp
that referenced
this pull request
Mar 28, 2022
Similar to mirage#791, but for the examples directory, which is a dependency of @runtest for cohttp-async. Signed-off-by: Aaron L. Zeng <me@bcc32.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upcoming Jane Street release, many of the libraries move from package
coretocore_unix(package preview: https://github.com/janestreet/core_unix).core_unix.v0.14.0is a compatibility package that is already on opam, so it should be possible to release this change before Jane Street packages v0.15 land.In fact some of our packages depend on
cohttp-async, so we'd appreciate it if a minor release that includes this change was made before we can release v0.15.Signed-off-by: Arseniy Alekseyev aalekseyev@janestreet.com