sexp for core cohttp types #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mirage/ocaml-uri#4 has a Sexp for Uri patch. I'll release that before merging this. |
now every type comes with sexp converters
Use the uri wrapper in the type definition
|
I've updated the PR for the new sexp'd version of uri |
|
Travis failing because of: |
| open Sexplib.Conv | ||
|
|
||
| let sexp_of_t t = | ||
| t |> to_list |> sexp_of_list (sexp_of_pair sexp_of_string sexp_of_string) |
There was a problem hiding this comment.
It would be useful to keep 4.00.1 compatibility for a little while, (since Mirage still supports it). Could this be rewritten without |> for now, and we can reintroduce them for 1.1.x?
mseri
added a commit
to mseri/ocaml-cohttp
that referenced
this pull request
Jun 16, 2022
Prepare to release 3.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sexpifying the core of cohttp