Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirage TLS support #37

Merged
merged 3 commits into from
Mar 20, 2015
Merged

Mirage TLS support #37

merged 3 commits into from
Mar 20, 2015

Conversation

talex5
Copy link
Contributor

@talex5 talex5 commented Jan 13, 2015

The first patch makes use of the new error_message function in mirage/mirage#346 to simplify error handling for flows.

The second patch adds TLS support. It's used like this:

    let mode = `TLS (tls_config, `TCP (`Port 8443)) in
    Conduit1.serve ~ctx ~mode (H.listen spec)

i.e. you pass in a TLS configuration and an underlying conduit specification and it wraps it.

This simplifies the code and will make it easier to wrap TLS flows.
@samoht
Copy link
Member

samoht commented Mar 16, 2015

This does not compile with tls.0.3.0. Which version did you use?

@talex5
Copy link
Contributor Author

talex5 commented Mar 16, 2015

0.3.0 is too old. It should work with the tls Git master.

@samoht
Copy link
Member

samoht commented Mar 16, 2015

Ok, so this needs a new release of ocaml-tls with mirleft/ocaml-tls#258

@hannesm
Copy link
Member

hannesm commented Mar 16, 2015

@samoht yes, this is true... and will happen soon. to work on xen, I believe gmp and zarith from mirage-dev need to be upstreamed as well

@talex5 talex5 force-pushed the tls branch 2 times, most recently from 9a7c86b to f20312a Compare March 16, 2015 20:49
@samoht
Copy link
Member

samoht commented Mar 20, 2015

I'm trying to make that PR to compile in #46. Given #25, I'll also try to use the new dynamic flows to simplify the API: we really cannot extend the library as we do currently.

@samoht samoht merged commit f20312a into mirage:master Mar 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants