Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize the application of password #4

Closed
wants to merge 1 commit into from

Conversation

dinosaure
Copy link
Member

Hello,

We need a function for the demand of password for SSL certificate in Ocsigenserver. But, I think this PR is not perfect (must I use a polymorphic variant for specify password ?).

@avsm
Copy link
Member

avsm commented May 20, 2014

Agreed; will merge this with the rest just as soon as I can finish the code review (this week I hope)

avsm added a commit to avsm/ocaml-conduit that referenced this pull request May 27, 2014
@avsm
Copy link
Member

avsm commented May 27, 2014

I've put in a Password and No_password explicit variant in the patch in order to match the rest of the interface. Will be merged into trunk shortly with the rest of the refactoring branch.

@avsm
Copy link
Member

avsm commented May 31, 2014

merged into trunk; not supported in async due to limitation of async_ssl for now

@avsm avsm closed this May 31, 2014
edwintorok pushed a commit to edwintorok/ocaml-conduit that referenced this pull request Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants