Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conduit-lwt-unix: allow openssl clients to customize the ssl context and the verification #417

Merged
merged 6 commits into from
Dec 14, 2022

Commits on Nov 30, 2022

  1. conduit-lwt-unix: create client ssl context on init

    The ssl context may be used for connect_with_ssl.
    
    When tls_own_key is not configured the configured ssl_ctx is used, by
    default this is the default client ssl_ctx, just as before.
    
    Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
    psafont committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    3ee0c11 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. conduit-lwt-unix: fail when hostname verification cannot be done on SSL

    When a valid hostname is not available it's better to fail early with
    a useful error message rather than letting the connection go on and
    letting OpenSSL fail with an undecipherable message.
    
    Note that the "hostname" parameters are strings and don't have to be
    hostnames, they can be IPs as well when using cohttp. Ideally these
    should be a union type of domain names and ip addresses for better
    clarity, but this would be a breaking change.
    
    Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
    psafont committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    9adfccf View commit details
    Browse the repository at this point in the history
  2. conduit-lwt-unix: Add flexibility for OpenSSL verification

    This is not exposed currently to the user, so there is no change in
    functionality.
    
    This allows clients to turn on and off hostname and ip verification in
    the remote cert independently in the unusual case where it's needed by
    changing the default in the library.
    
    Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
    psafont committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    a9706eb View commit details
    Browse the repository at this point in the history
  3. conduit-lwt-unix: allow users to configure client ssl verification

    The only options allowed are whether the hostname or the IP are used to
    validate the remote host's certificate
    
    Signed-off-by: Pau Ruiz Safont <pau.safont@citrix.com>
    psafont committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    a1634a8 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. conduit-lwt-unix: Change verification and SNI when using IP to connect

    Now the SNIs is only sent when there's a domain name, as this is the
    only type of server names allowed by the RFC
    
    Additionally IP verification for the peer certificate can be enabled if
    needed
    
    Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
    psafont committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    f0dfae6 View commit details
    Browse the repository at this point in the history
  2. changes: add entries regarding conduit-lwt-unix-ssl

    Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
    psafont committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    1a46ae3 View commit details
    Browse the repository at this point in the history